Skip to content

BDMS-431; BDMS-437#346

Merged
jirhiker merged 5 commits into
stagingfrom
BDMS-431-Migrate-ChemistrySampleInfo
Jan 8, 2026
Merged

BDMS-431; BDMS-437#346
jirhiker merged 5 commits into
stagingfrom
BDMS-431-Migrate-ChemistrySampleInfo

Conversation

@jirhiker

@jirhiker jirhiker commented Jan 8, 2026

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Add legacy Chemistry SampleInfo support for backfill workflows
  • Provide a backfill routine and include it in staging backfill runs
  • Limit pre-commit to black + flake8 via a local-only config

How

Implementation summary - the following was changed / added / removed:

  • Added ChemistrySampleInfo model in db/nma_legacy.py with the requested fields (minus LocationId/SSMA_TimeStamp)
  • Added Alembic migration to create the Chemistry_SampleInfo legacy table
  • Added a backfill script to upsert Chemistry_SampleInfo from CSV and wired it into transfers/backfill/staging.py
  • Added .pre-commit-config.local.yaml and updated .git/hooks/pre-commit to use it

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Backfill is idempotent via ON CONFLICT DO UPDATE on OBJECTID

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1577da93b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread db/nma_legacy.py
@jirhiker jirhiker changed the title BDMS-431 BDMS-431; BDMS-437 Jan 8, 2026
@jirhiker jirhiker merged commit 86a3913 into staging Jan 8, 2026
6 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the BDMS-431-Migrate-ChemistrySampleInfo branch February 26, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant